Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSL (FTPS) via environment options #41

Open
kedarac opened this issue Oct 9, 2019 · 7 comments · May be fixed by #42
Open

Support SSL (FTPS) via environment options #41

kedarac opened this issue Oct 9, 2019 · 7 comments · May be fixed by #42
Labels
enhancement look

Comments

@kedarac
Copy link

kedarac commented Oct 9, 2019

Add a way to pass SSL key and certificate to enable Secure FTP (SFTP).

vsftpd supports the following via its conf file:

ssl_enable=YES
allow_anon_ssl=NO
force_local_data_ssl=YES
force_local_logins_ssl=YES
ssl_tlsv1=YES
ssl_sslv2=NO
ssl_sslv3=NO
require_ssl_reuse=NO
ssl_ciphers=HIGH
rsa_cert_file=/etc/vsftpd.pem
rsa_private_key_file=/etc/vsftpd.pem
pasv_max_port=65535
pasv_min_port=64000
@artjomsk
Copy link

artjomsk commented Oct 9, 2019

pasv_max_port and pasv_min_port are not related to SSL and have been already supported by environment variables: PASV_MAX_PORT and PASV_MIN_PORT

artjomsk pushed a commit to artjomsk/docker-vsftpd that referenced this issue Oct 10, 2019
fauria#41 Support SSL(FTPS) via environment variables
6cd62e9
@artjomsk artjomsk linked a pull request Oct 10, 2019 that will close this issue
Open
@artjomsk
Copy link

SFTP is completely another story where vsftpd isn't needed at all, but support for FTPS (FTP + SSL) can be easily done. Watch my pull request - #42

artjomsk added a commit to artjomsk/docker-vsftpd that referenced this issue Oct 10, 2019
@artjomsk
Merge pull request #1 from artjomsk/41-support-ssl
57937bc 
fauria#41 Support SSL(FTPS) via environment variables
@kedarac
Copy link
Author

kedarac commented Oct 14, 2019 •
edited
Loading

Thanks for the quick response on the issue.

pasv_max_port and pasv_min_port are not related to SSL

Yes, I understand these are already supported. I pasted 2 extra lines while referring from a blog post.

Regarding SFTP and FTPS, I was not clear that they both were different things. Now that I read about them, I am editing the issue title.

@fauria This issue can be closed once you accept the MR.

@kedarac kedarac changed the title Support SSL (SFTP) via environment options Support SSL (FTPS) via environment options Oct 14, 2019
siwadon pushed a commit to siwadon/docker-vsftpd that referenced this issue Jan 31, 2020
@siwadon
fauria#41 Support SSL(FTPS) via environment variables
79738bb
printesoi added a commit to printesoi/docker-vsftpd that referenced this issue Mar 25, 2020
@printesoi
fauria#41 Add support for SSL
93abdac
evantill pushed a commit to evantill/docker-vsftpd that referenced this issue Jun 24, 2020
@evantill
fauria#41 Support SSL(FTPS) via environment variables
22d71f3
@lucaskuperman
Copy link

@fauria Any ETA for supporting SSL?

@fauria
Copy link
Owner

fauria commented Sep 3, 2020

We need to be careful here to avoid breaking non-SSL deployments. I'll have a look at this ASAP, but can't guarantee an ETA at the time, unfortunately.

@markhobson
Copy link

It'd be great to get this FTPS support merged.

In the meantime, @artjomsk would you be able to rebase your fork so it includes the recent PASV_PROMISCUOUS support? I'm in the unfortunate position of needing both that and TLS, and I'd rather not create yet another fork! I've rebased locally and it's pretty straightforward. Thanks :)

@markhobson
Copy link

I went ahead and created a fork: markhobson/docker-vsftpd
Available on Docker Hub: markhobson/vsftpd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement look
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#41 Support SSL(FTPS) via environment variables artjomsk/docker-vsftpd
5 participants
@markhobson @lucaskuperman @fauria @kedarac @artjomsk