Cannot create Rawhide side tag update when the package has no %dist tag

[hroncok]

I built fedora-obsolete-packages-41-5 in a rawhide side tag.

I proceed to create a Bodhi update from that side tag.

Bodhi told me:

This is incorrect. The build was tagged to f41-build-side-93643 which is a Fedora 41 side tag. Bodhi should not attempt to parse the -5 release as EL5.

I fixed this by koji tag f41-updates-candidate fedora-obsolete-packages-41-5 which successfully created a Fedora 41 update: https://bodhi.fedoraproject.org/updates/FEDORA-2024-26e04543f7

[mattiaverga]

bodhi/bodhi-server/bodhi/server/validators.py

Lines 206 to 216 in 2510b53

	cache_nvrs(request, build)
	if request.validated.get('from_tag'):
	n, v, r = request.buildinfo[build]['nvr']
	release = request.db.query(Release).filter(or_(Release.name == r,
	Release.name == r.upper(),
	Release.version == r)).first()
	if release and release.composed_by_bodhi:
	request.errors.add(
	'body', 'builds',
	f"Can't create update from tag for release"
	f" '{release.name}' composed by Bodhi.")

This validator has no sense to me.
First of all, in n, v, r = request.buildinfo[build]['nvr'] the r refers to the release of the RPM, not the Release which the build refers to. So this, at least, has never worked as planned.

Then, why creating an update from tag should not be allowed for releases composed by Bodhi? Maybe this is a leftover of the time when sidetags were only allowed in Rawhide?