Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search appears to have become case-sensitive again #5756

Open
keszybz opened this issue Oct 7, 2024 · 3 comments
Open

search appears to have become case-sensitive again #5756

keszybz opened this issue Oct 7, 2024 · 3 comments

Comments

@keszybz
Copy link

keszybz commented Oct 7, 2024

https://bodhi.fedoraproject.org/updates/?packages=Systemd → nada
https://bodhi.fedoraproject.org/updates/?packages=systemd → voilà

Resurfacing of #997.

@mattiaverga
Copy link
Contributor

I don't think this was regressed, it always worked this way.

#997 was solved by adding a new case insensitive ?search= term. The usage of search or packages depends on what output user wants:

Note that 3 and 4 include updates from other packages with similar name (e.g. sway-systemd), so they're not equal replacement for a case insensitive package search.

However, package systemd is not the same as package Systemd (maybe is just a rename, like KPMcore and kpmcore, maybe not). So rather than changing the default behavior, I was thinking we could add a flag to switch from case sensitive to case insensitive - something like updates/?packages=Systemd&case_sensitive=false.

Other thoughts?

@keszybz
Copy link
Author

keszybz commented Oct 8, 2024

OK, so it sounds like a problem on my side. If this is intentional, then let's just close this issue.

@mattiaverga
Copy link
Contributor

It depends on what you need... Bodhi is indeed currently missing a way to query updates specifying an exact package name, but case insensitive. One may argue that "exact package name" should also be aware of uppercase/lowercase.

If you have a use case where this is needed, we could implement in the way I described before to not broke existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants