Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New check: Metadata invalid minisite_url #4739

Open
2 of 8 tasks
vv-monsalve opened this issue May 23, 2024 · 2 comments
Open
2 of 8 tasks

New check: Metadata invalid minisite_url #4739

vv-monsalve opened this issue May 23, 2024 · 2 comments
Assignees
Labels
GF's priority list List of high priority issues for google/fonts CI New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone

Comments

@vv-monsalve
Copy link
Collaborator

What needs to be checked?

If minisite_url has a random text instead an http:// + domain string the push to dev gets broken.

Resources and steps needed to reproduce the problem

(Provide the steps and files for reproducing the problem. We will need them for developing the proposed check and for including them in tests that validate the codebase)

Suggested profile

Suggest which profile the check should be added to. The most common are:

  • Vendor-specific: Google Fonts
  • Vendor-specific: Adobe Fonts
  • OpenType (requirements imposed by the OpenType specification)
  • Universal (broadly accepted best practices on the type design community)
  • Other:

Suggested result

Which log result level should the check have:

  • ☠️ FATAL
  • 🔥 FAIL (An issue that must be corrected for the font to function properly)
  • ⚠️ WARN (A potential issues that may need to be addressed)

Severity assessment

5, causes servers to fail.

@vv-monsalve vv-monsalve added New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id GF's priority list List of high priority issues for google/fonts CI labels May 23, 2024
@vv-monsalve
Copy link
Collaborator Author

This happened here https://github.com/google/fonts/pull/7762/files

@felipesanches felipesanches self-assigned this May 23, 2024
@felipesanches felipesanches added this to the 0.12.7 milestone May 23, 2024
@felipesanches
Copy link
Collaborator

we already have com.google.fonts/check/metadata/minisite_url, but it only alerted us when decluttering was needed (such as removing extra white-space). I'll add a URL check to see if the url is not broken, Similar to other URL checks, if it doesn't return a 404 HTTP error code, then it means it is a good URL.

felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 23, 2024
com.google.fonts/check/metadata/minisite_url
On the Google Fonts profile.

(issue fonttools#4739)
@felipesanches felipesanches modified the milestones: 0.12.7, 0.12.8 Jun 4, 2024
@felipesanches felipesanches modified the milestones: 0.12.8, 0.12.9 Jul 5, 2024
@felipesanches felipesanches modified the milestones: 0.12.9, 0.12.10 Jul 17, 2024
@felipesanches felipesanches modified the milestones: 0.12.10, 0.12.11 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GF's priority list List of high priority issues for google/fonts CI New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Development

No branches or pull requests

2 participants