-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New check: Metadata invalid minisite_url #4739
Labels
GF's priority list
List of high priority issues for google/fonts CI
New check proposal
We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
Comments
vv-monsalve
added
New check proposal
We expect new check proposals to include a detailed rationale description and a suggested check-id
GF's priority list
List of high priority issues for google/fonts CI
labels
May 23, 2024
This happened here https://github.com/google/fonts/pull/7762/files |
we already have com.google.fonts/check/metadata/minisite_url, but it only alerted us when decluttering was needed (such as removing extra white-space). I'll add a URL check to see if the url is not broken, Similar to other URL checks, if it doesn't return a 404 HTTP error code, then it means it is a good URL. |
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
felipesanches
added a commit
to felipesanches/fontbakery
that referenced
this issue
May 23, 2024
com.google.fonts/check/metadata/minisite_url On the Google Fonts profile. (issue fonttools#4739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GF's priority list
List of high priority issues for google/fonts CI
New check proposal
We expect new check proposals to include a detailed rationale description and a suggested check-id
What needs to be checked?
If minisite_url has a random text instead an
http://
+domain
string the push to dev gets broken.Resources and steps needed to reproduce the problem
(Provide the steps and files for reproducing the problem. We will need them for developing the proposed check and for including them in tests that validate the codebase)
Suggested profile
Suggest which profile the check should be added to. The most common are:
Suggested result
Which log result level should the check have:
Severity assessment
5, causes servers to fail.
The text was updated successfully, but these errors were encountered: