Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com.fontwerk/check/style_linking] Should Pass fonts with Platform mac name ID 2 name not italic? #4762

Open
guidoferreyra opened this issue Jun 7, 2024 · 2 comments

Comments

@guidoferreyra
Copy link
Contributor

Observed behaviour

On a font that has properly set fsSelection and macStyle to Italic but the name record 2 for mac platform is not Italic the check raises a FAIL:

MyFont-BookOblique.otf
FAIL :
name ID should be (most likely) 'Italic'.

AFAIK the limitation of ID 2 to be only Regular, Bold, Italic, Bold Italic is only for win platform.

Should the check be more specific here?

if ttFont["name"].getDebugName(2) not in ("Italic", "Bold Italic"):

cc @ollimeier

@guidoferreyra guidoferreyra changed the title [com.fontwerk/check/style_linking] Should accept failing on fonts with Platform mac name ID 2 name not italic. [com.fontwerk/check/style_linking] Should Pass fonts with Platform mac name ID 2 name not italic? Jun 7, 2024
@ollimeier
Copy link
Contributor

Thanks @guidoferreyra for the hint, but this is intended. Even though you're right, the real world shows different rules. When eg. Mac and Win name ID is different, it causes other issues like cross platform issues. To be on the save side, we stick to Regular, Bold, Italic, Bold Italic also for Mac entries. This is based on experiences I made over years in Quality Assurance.

cc @fontwerk

@guidoferreyra
Copy link
Contributor Author

Thanks for the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants