Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for make.py checks #156

Open
5 tasks
pdeiml opened this issue Aug 29, 2017 · 1 comment
Open
5 tasks

Fixup for make.py checks #156

pdeiml opened this issue Aug 29, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@pdeiml
Copy link
Collaborator

pdeiml commented Aug 29, 2017

This is a issue which is intended to collect all fixups which are related to 'make.py checks'. It also collects everything which should be but have not been implemented in 'make.py checks'.
Feel free to start a discussion about something!

  • @cdeil Please write down a short sentence about issue_123 (close and reference issue_123 afterwards?)
  • @cdeil Please write down a short sentence about issue_54 (close and reference issue_123 afterwards?)
  • Do all references in /input/sources/ have a corresponding folder and file in /input/data and vice versa
  • Printing a table with 'source_id', 'data_entry_status', 'review_required' as columns. 'data_entry_status' and 'review_required' refers to the keywords of the same name.
  • Check the name of the folder in /input/data// with the keywords reference_id given in the files in the folders
@cdeil
Copy link
Contributor

cdeil commented Jan 25, 2018

Suggest to discuss and do improvements for the scripts one step at a time and to close this issue. That's just pragmatic, given that no-one has a week to do the re-write.

Generally there should be some checks that no old files are around in the input and output folder and all files are in the index files. And then all other checks should start with the index files.

When referencing other GH issues, use th # character, so that a link is created. In this case you mentioned #54 and #123 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants