Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gammapy compatibility completely gone #243

Open
mireianievas opened this issue Dec 4, 2020 · 0 comments
Open

Gammapy compatibility completely gone #243

mireianievas opened this issue Dec 4, 2020 · 0 comments

Comments

@mireianievas
Copy link

Hi,

There are a few classes that were removed in recent gammapy versions (>0.9) that completely break compatibility in gammacat. In particular, GammaCatResource, GammaCatResourceIndex, GammaCatDataCollection are gone from gammapy.catalog.gammacat.py

I managed to run it with gammapy 0.9 and compile everything, with the following quick and dirty fixes:

gammapy.spectrum.models.py L860: cutoff = np.exp(-(energy * lambda_).value) [add the .value at the end, otherwise it is not a proper floating number]
gammapy.spectrum.utils.py L261: n = int((logmax - logmin) * ndecade) [add the int(), otherwise it is a float and it does not work in subsequent lines]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant