-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release spirv:0.3.0+sdk-1.3.243.0
not on crates.io
#245
Comments
This would require a semver version bump to |
spirv:0.2.0+sdk-1.3.243.0
not on crates.iospirv:0.3.0+sdk-1.3.243.0
not on crates.io
Yeah, you won't be allowed to publish the same version ( The metadata has been bumped when we pushed the last regeneration, but it never made it to a release yet. |
@MarijnS95 Are there any blockers to getting a new release pushed? I think merging my pr #244 should handle all the code changes, on the other hand just publishing the current master as |
@exrook the main blocker is me not having any maintainer rights whatsoever. This not only makes me unable to help out with your request right now, it also makes it less enticing to contribute consistent improvements and updates as well as perform code reviews and maintenance. |
@MarijnS95 Ah that's unfortunate, sorry for barking up the wrong tree. Thanks for looking at this anyways though :). Do you know which of the maintainers would be most likely to help? I don't want to burden anyone who doesn't have time to work on this, but I would really appreciate seeing a new release to crates.io eventually. Alternatively, maybe we can get someone from the @gfx-rs org to step in if the current maintainers don't have bandwidth to work on this crate at the moment. |
Maybe @msiglreith is most active to help us out? |
Unfortunately I don't have publishing rights for the crate either see https://crates.io/crates/rspirv |
Maybe we could at least get some PRs reviewed and merged, then have some more folks with publishing rights or set up a crates.io token in CI for automated publishes. |
@MarijnS95 @msiglreith I've sent invites to you to the rspirv crate. I won't have bandwidth to handle in the forseeable future unfortunately; but would like to see this continues to be supported in good hands. Let me know if there are any other blockers. Thanks again! :) |
With the publishing rights problem seemingly resolved, could we get an update on crates.io? I would very much be interested in the symbols for mesh shaders. And thanks for your efforts to get it updated :D |
Aiming to release a new version in the next days |
@Firestar99 it's being worked on already, see active PRs (#248). |
Could someone add me to |
@msiglreith sent! Do you have the rights on this repo to add secret tokens? Because I don't 😅 |
@msiglreith I've published the release for Though in hindsight GitHub supports simply re-running a CI job, which might have solved this as well if your API key in GitHub secrets is allowed to publish to this crate. |
@MarijnS95 Thanks! Yes, as I can add tokens as I'm organization owner heh - I increased your rights to I created and published a new
Anyway, new |
Nope, only have access to a few basic settings. Thanks anyway! The crates are said to be a "pattern", perhaps there's no check to see if it matches anything (in case you haven't published it yet... But also in case your pattern matches another crate that already exists but is not yours?)
Yes, this is a little terrible situation, but not sure how it is supposed to be fixed. Maybe only works with individual releases or with |
It would be nice to have
0.3.0+sdk-1.3.243.0
available on crates.io.Alternatively, merge my pr #244 that updates to
sdk-1.3.268.0
, then push a new crates.io release :)The text was updated successfully, but these errors were encountered: