Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byte is reserved word #4

Open
ghost opened this issue Apr 7, 2017 · 1 comment
Open

byte is reserved word #4

ghost opened this issue Apr 7, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 7, 2017

I get an error:

grunt-google-closure-compiler: /../build/tmp/libs.js:19720: ERROR - Parse error. identifier is a reserved word
writeByte: function(byte) {
^
...

Line 163:
/** Serializes a number /
writeByte: function(byte) {
if ( byte <= Math.pow(2,31)
-1 || byte >= Math.pow(2,31) ) {
throw new Error(byte + " is incorrect for byte.");
}
this.buffer.push(byte);
},

radekg added a commit that referenced this issue Apr 7, 2017
@radekg
Copy link
Member

radekg commented Apr 7, 2017

Hi @procoru, would you mind trying from this branch? https://github.com/gossiperl/thrift-js-binary-protocol/tree/byte-reserved-word

radekg added a commit that referenced this issue Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant