Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeNumbersTask example doesn't compile #1

Open
shnplr opened this issue Oct 10, 2015 · 2 comments
Open

PrimeNumbersTask example doesn't compile #1

shnplr opened this issue Oct 10, 2015 · 2 comments

Comments

@shnplr
Copy link

shnplr commented Oct 10, 2015

  1. There is no default constructor in AbstractTask i.e. the example should call super(String).

    public PrimeNumbersTask(int numbersToFind) {
    super("")
    //initialize
    }

  2. The return type of execute does not match the interface definition <V, C>
    i.e. shouldn't it return a List?

    @OverRide
    public List execute(Tracker tracker) throws Exception {
    while (!enough && !isCancelled()) {

@shnplr
Copy link
Author

shnplr commented Jan 16, 2016

also perhaps

  1. add process() method in the example to demonstrate UI control responding to publish(number)
  2. show how the reference to 'taskManager' is created e.g. injected into a griffon controller
  3. show how to create a taskId to register events on TaskManager
  4. for javafx toolkit users any advice vs using native javafx task

@aalmiray
Copy link
Member

The newly uploaded sample application gives more details on how this plugin can be used. It's not the final solution though as I believe it can be simplified even further, but it's a good start to get the feeling of the API. The guide will be updated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants