You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest version of the chart doesn't add a targetPort for both the service and deployment resources when PrometheusMetrics is enabled because the template is looking for enabled but not Enabled (which is case sensitive). The following will trigger the port to be added but of course, will fail the config parsing:
PrometheusMetrics:
Enabled: true
enabled: true
Snippet of the helm diff output for the Service resource after setting enabled: true:
… PrometheusMetrics is enabled (#274)
<!--
Thank you for contributing to the project! 💜
Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->
## Which problem is this PR solving?
<please describe the issue>
- Closes#273
## Short description of the changes
- Fixes typo where `enabled` was used instead of `Enabled`
## How to verify that this has the expected result
Tested with `helm template`
Versions
Chart: 2.1.0
Helm: 3.11.2
Kubernetes cluster: 1.23
Steps to reproduce
The latest version of the chart doesn't add a targetPort for both the service and deployment resources when PrometheusMetrics is enabled because the template is looking for enabled but not Enabled (which is case sensitive). The following will trigger the port to be added but of course, will fail the config parsing:
Snippet of the helm diff output for the Service resource after setting enabled: true:
Additional context
Only workaround is to fork the Chart and fix it with on both service and deployment templates:
The text was updated successfully, but these errors were encountered: