Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point at which dataContext.IsComplete is checked for force stopping rules. #455

Open
v15ha1 opened this issue Jul 23, 2024 · 0 comments
Open

Comments

@v15ha1
Copy link

v15ha1 commented Jul 23, 2024

Is your feature request related to a problem? Please describe.

The BeginCycle() in the EngineListener can be used as application level pre-check and can call the DataContext.Complete(), if the pre-checks fail. However in the current ExecuteWithContext() function, the
if dataCtx.IsComplete() { break }
is completed only after the current Execution cycle completes.

Describe the solution you'd like
Add
if dataCtx.IsComplete() { break }
to the beginning of the for loop in the ExecuteWithContext() function.

Describe alternatives you've considered
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant