Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock in SingletonScope for circular dependencies #10

Open
bastianccm opened this issue May 20, 2019 · 0 comments
Open

Deadlock in SingletonScope for circular dependencies #10

bastianccm opened this issue May 20, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@bastianccm
Copy link
Contributor

The Circular Dependency check is unable to detect circular dependencies in singletons, as the Singleton will deadlock before the detection happens.

Testcase:

type circSingletonA struct {
	B *circSingletonB `inject:""`
}
type circSingletonB struct {
	A *circSingletonA `inject:""`
}

func TestCircularSingletonBinding(t *testing.T) {
	EnableCircularTracing()
	defer func() {
		traceCircular = nil
	}()
	injector := NewInjector()
	injector.Bind(new(circSingletonA)).In(Singleton)
	injector.GetInstance(new(circSingletonA))
}
@bastianccm bastianccm added the bug Something isn't working label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant