Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add multi node (validator) testnet #4377

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: Add multi node (validator) testnet #4377

wants to merge 22 commits into from

Conversation

likesToEatFish
Copy link
Contributor

@likesToEatFish likesToEatFish commented Sep 29, 2024 •
edited
Loading

Closes: #4374

This PR added the feature to ignite multi-node testnet.

Test steps:

  1. ignite scaffold chain github.com/test/mychain
  2. cd mychain
  3. go install ./...
  4. ignite testnet multi-node

The interface looks like this:

image

@likesToEatFish
Copy link
Contributor Author

likesToEatFish commented Sep 29, 2024 •
edited
Loading

The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow.

@likesToEatFish likesToEatFish changed the title INIT: Multi Node (Validator) Testnet INIT: Add multi node (validator) testnet Sep 29, 2024
@julienrbrt julienrbrt changed the title INIT: Add multi node (validator) testnet feat: Add multi node (validator) testnet Sep 29, 2024
julienrbrt
julienrbrt reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up so fast! This is a good start 🙏🏾

ignite/cmd/model/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/cmd/model/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/cmd/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/config/chain/base/config.go Outdated Show resolved Hide resolved
ignite/services/chain/runtime.go Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush Outdated Show resolved Hide resolved
ignite/config/chain/base/config.go Outdated Show resolved Hide resolved
ignite/cmd/testnet_multi_node.go Show resolved Hide resolved
@julienrbrt
Copy link
Member

Hey, we've changed a bit the requirements and simplified the config.yaml: #4374 (comment)

In short, we should use the existing validators section for multi-node.
We should add a comments that says the fist validator is used in chain serve and all validators are used in testnet multi-node.
For random, less not have them in the config.yaml anymore, but just let multi-node take a flag.

@github-actions github-actions bot added the component:docs Documentation additions or improvements. label Oct 2, 2024
@likesToEatFish
Copy link
Contributor Author

Here is the new display result, there will be 5 daemon lines for each node:

image

@likesToEatFish
Copy link
Contributor Author

likesToEatFish commented Oct 5, 2024 •
edited
Loading

we should use the existing validators section for multi-node.

And I modified the use of the existing validators section for multi-node.

julienrbrt
julienrbrt reviewed Oct 9, 2024
View reviewed changes
ignite/cmd/bubblemodel/testnet_multi_node.go Show resolved Hide resolved
ignite/cmd/bubblemodel/testnet_multi_node.go
output += " ]\n\n"
}

output += "Press q to quit.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a sort of colored status bar (https://github.com/charmbracelet/lipgloss) that would let you quit a specific node

ignite/cmd/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/cmd/testnet_multi_node.go Outdated Show resolved Hide resolved
ignite/pkg/chaincmd/runner/chain.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@likesToEatFish likesToEatFish

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INIT: Multi Node (Validator) Testnet
2 participants
@likesToEatFish @julienrbrt