Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBOR value codec #67

Open
masih opened this issue Aug 19, 2022 · 1 comment
Open

Add CBOR value codec #67

masih opened this issue Aug 19, 2022 · 1 comment

Comments

@masih
Copy link
Member

masih commented Aug 19, 2022

Add COBR value codec and benchmarks that compare it with the existing JSON and custom binary format. Set CBOR as default if its performance is comparable with the custom binary format in favour of using more common data formats.

@gammazero
Copy link
Collaborator

If there is never a consumer of the valuestore's index data, outside of our own indexer-core implementation, then I suggest that we do not need this, and this issue should be closed.

If someone wants to write their own custom core by implementing the interfaces in this repo, then they are welcome to include whatever codec they want. It is not necessary to offer them a full menu of codecs to choose from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants