-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help user interpret param columns of cv_results_ #5
Comments
what if |
I don't mind the idea of having some kind of name_ parameter to set_grid,
but we would have to have a custom GridSearchCV.fit implementation in order
to do the rename in cv_results_, so there may be substantial maintenance
overhead and additional complexity for the user who now has to appreciate
that sklearn.model_selection.GridSearchCV and searchgrid.GridSearchCV are
distinct classes. But it might be justifiable
… |
Ah, I see. Having a custom GridSearchCV would be a good deal more overhead. I'm not very familiar with sklearn's GridSearchCV details under the hood, so I was hoping that this wouldn't need to reimplement anything. Let me familiarize myself more with that part of the sklearn codebase a little more. |
It wouldn't need to copy the GridSearchCV code, just use inheritance, so
it's not a huge deal, it just might confuse users... Maybe worthwhile.
|
Because the user no longer specifies the grid by full names, results are then presented with param names that are unfamiliar and which will vary with
The user needs help dereferencing the parameters. What is a good API for this?
The text was updated successfully, but these errors were encountered: