Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track only PR changes #16

Open
manuelmhtr opened this issue Aug 15, 2023 · 4 comments
Open

Track only PR changes #16

manuelmhtr opened this issue Aug 15, 2023 · 4 comments

Comments

@manuelmhtr
Copy link

Hi @joshmfrankel,
Thanks for building this amazing action. As an idea, it would be great to have an option to check coverage only agains changed files.

This could increase the adoption of existing projects with not enough coverage.

@gathuku
Copy link

gathuku commented Jan 29, 2024

@manuelmhtr Have you found any workaround on this?

@manuelmhtr
Copy link
Author

@gathuku unfortunately no. I'd suggest starting with a very relaxed coverage policy (or ignoring some paths) and then moving gradually to your ideal policy.

@gathuku
Copy link

gathuku commented Jan 29, 2024

Sound cool @manuelmhtr , no problem.

@joshmfrankel
Copy link
Owner

@manuelmhtr has the approach I would take here. Gradual increase of the coverage threshold until you reach the desired amount. Changed files would be a great addition to the action. In theory, I believe you could diff the incoming Pull Request changed files from GitHub and compare it to the SimpleCov results and fail as necessary. I'd be willing to look over any PRs that implement this as I sadly don't have the time right now to build it :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants