Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6

Open
lzilioli opened this issue Dec 5, 2023 · 0 comments
Open

Fixes #6

lzilioli opened this issue Dec 5, 2023 · 0 comments

Comments

@lzilioli
Copy link

lzilioli commented Dec 5, 2023

I fixed a number of issues in this plugin that was preventing it from working on my vault. At least some of these changes should probably get incorporated into the mainline branch.

  • Differentiate between stdout and stderr in debug output (8955f7e)

  • Use console.error for error messages (c843f6d)

  • Escape spaces in file paths (69ccc04)

    • this one seems like it would be necessary for anyone trying to use this plugin within an icloud synced obsidian vault
  • Prevent insertion of empty details (49a208e)

    • if the call to tesseract fails, this plugin should not insert empty details–the user should have a chance to debug and fix the plugin setup
  • Split functionality into two commands (fd47b66)

    • adds command to run ocr against the current file only
  • Support legacy style links (ca0e3af)

    • this one is probably specific to my needs, but it takes older style links e.g. [test.jpg](../../uploads/test.jpg) and rewrites them to wiki style links so that the rest of the plugin code works. This could be tied to a setting if people think it would be useful, otherwise its a bit destructive and could be dropped.

    Please refer Lzilioli improvements #7 for the code changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant