Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

As knative admin, I want to unset custom domain #29

Closed
ZhuangYuZY opened this issue May 15, 2020 · 4 comments
Closed

As knative admin, I want to unset custom domain #29

ZhuangYuZY opened this issue May 15, 2020 · 4 comments
Assignees
@ZhuangYuZY

Comments

@ZhuangYuZY
Copy link
Contributor

Now we have kn admin domain set to set custom-domain. But we are missing to unset the custom domain if it is not used or incorrect.

unset Knative route domain for service

For example:
# To unset a route domain
kn admin domain unset --custom-domain mydomain.com

Usage:
  kn admin domain unset [flags]

Flags:
  -d, --custom-domain string  Custom domain to unset
  -h, --help                   help for unset

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)
@ZhuangYuZY
Copy link
Contributor Author

ZhuangYuZY commented May 15, 2020 •
edited
Loading

/assign
I would work on this new command.

@ZhuangYuZY
Copy link
Contributor Author

ZhuangYuZY commented May 18, 2020 •
edited
Loading

Function code is ready, now I am waiting on #14, then add test for unset. Thank you.

@ZhuangYuZY ZhuangYuZY mentioned this issue May 30, 2020
Merged
@ZhuangYuZY
Copy link
Contributor Author

PR submitted, #38

@ZhuangYuZY
Copy link
Contributor Author

PR merged, closing...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZhuangYuZY ZhuangYuZY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZhuangYuZY