Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

[kn-admin] As a Knative administrator, I want to enable https connections for all services using existing certificate #67

Open
chaozbj opened this issue Jul 10, 2020 · 2 comments
Assignees

Comments

@chaozbj
Copy link
Contributor

chaozbj commented Jul 10, 2020

From the @zhanggbj's proposal doc:

In production, usually we would like to provide https connection for applications or Knative Services. To enable https connection, kn-admin will take an existing certificate and enable https-connection with the CLI instead of creating a Secret and modifying Gateway as Knative Serving doc described.

$ kn admin https-connection enable --tls-cert ${workspace}/demo.pem --tls-key ${workspace}/demo.key
Knative serving https connection is enabled

# In fact, kn admin will create a secert in istio-system and config the routing rules in knative-ingress-gateway
$ kubectl get secret -n istio-system istio-ingressgateway-certs
$ kubectl get gateway knative-ingress-gateway --namespace knative-serving
@chaozbj
Copy link
Contributor Author

chaozbj commented Jul 10, 2020

/assign

@zhanggbj
Copy link

@chaozbj The proposal doc cover the default istio ingressgateway config and only support one secret.
However since istio 1.6, SDS is enabled by default, and it can support multiple secrets.
We may need to support both situations, so need to check whether Istio SDS is enabled first and then do the corresponding configs.

Also CC @maximilien

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants