Consider implementing all methods directly on their respective types #67
Labels
Comments
timokroeger
added a commit
to timokroeger/bxcan
that referenced
this issue
Dec 14, 2020
Lot’s of duplication, not sure if that’s best practice. Ref: lpc-rs/lpc8xx-hal#67
timokroeger
added a commit
to timokroeger/bxcan
that referenced
this issue
Dec 14, 2020
Lots of duplication, not sure if that’s best practice. Ref: lpc-rs/lpc8xx-hal#67
timokroeger
added a commit
to timokroeger/bxcan
that referenced
this issue
Dec 14, 2020
Lots of duplication, not sure if that’s best practice. Ref: lpc-rs/lpc8xx-hal#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, functionality covered by embedded-hal is only implemented via the embedded-hal traits. This means anyone using those methods must import the traits.
It might be more convenient to implement all methods directly on the types, and offer the traits in addition. Then the trait methods would basically just proxy the inherent implementations. I'm not sure though if there are any complications here regarding name collisions between trait methods and inherent methods.
The text was updated successfully, but these errors were encountered: