-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix finding child content-type elements in stage-builder #869
Open
orukusaki
wants to merge
4
commits into
magento:develop
Choose a base branch
from
orukusaki:fix-child-content-finding
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orukusaki
force-pushed
the
fix-child-content-finding
branch
from
May 13, 2024 15:05
f34d6de
to
1bfc575
Compare
engcom-Bravo
added
the
Triage: Dev.Experience
Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
label
Sep 13, 2024
@magento run all tests |
@magento create issue |
5 tasks
engcom-Hotel
approved these changes
Sep 24, 2024
m2-community-project
bot
added
Progress: ready for testing
and removed
Progress: ready for review
labels
Sep 24, 2024
Hello @orukusaki, ❌ QA not Passed We have tried reproducing the issue by following the Please refer to the below custom module we have made to reproduce the issue: Please let us know if we missed anything. Thanks |
engcom-Hotel
added
Progress: needs update
and removed
Progress: ready for testing
labels
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Progress: needs update
Project: Community Picked
PRs upvoted by the community
Triage: Dev.Experience
Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixes a bug whereby child content-type elements will not be found, where other types of elements also exist at the same level.
Manual testing scenarios (*)
master.html:
preview.html:
It is possible to create this content type in Pagebuilder, and the correct result is rendered into the database and on the frontend. However, Pagebuilder cannot then load up the content back into the stage - the presence of the
<li>
element causes only the last item to be found, and<div class="swiper-scrollbar">
causes even that to be forgotten.This small fix corrects this, and all types of content can now be loaded into the stage correctly.
Checklist
Resolved issues: