You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Method "setBody" of class "Create" has unnecessary line # 37 (of origin file /phpClient/vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Endpoints/Indices/Create.php).
See comment inside code:
public function setBody($params = null)
{
if (isset($this->index)) {
$columns = [];
if (isset($params['columns'])) {
foreach ($params['columns'] as $name => $settings) {
$column = $name . ' ' . $settings['type'];
if (isset($settings['options']) && count($settings['options']) > 0) {
$column .= ' ' . implode(' ', $settings['options']);
}
$columns[] = $column;
}
}
$options = "";
if (isset($params['settings'])) {
foreach ($params['settings'] as $name => $value) {
$options.=" ".$name." = '".$value."'"; // ##### <----- this line is unneccessary, because the same code lower in "else" block
if (is_array($value)) {
foreach ($value as $v) {
$options.=" ".$name." = '".$v."'";
}
} else {
$options.=" ".$name." = '".$value."'"; // #### <----- the same code
}
}
}
return parent::setBody(['query' => "CREATE TABLE ".
(isset($params['silent']) && $params['silent']===true?' IF NOT EXISTS ':'').
$this->index.
(count($columns)>0?"(".implode(",", $columns).")":" ")
.$options]);
}
throw new RuntimeException('Index name is missing.');
}
The text was updated successfully, but these errors were encountered:
Method "setBody" of class "Create" has unnecessary line # 37 (of origin file /phpClient/vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Endpoints/Indices/Create.php).
See comment inside code:
The text was updated successfully, but these errors were encountered: