Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multipart requests for Typescript #5256

Closed
2 tasks
rkodev opened this issue Aug 27, 2024 · 3 comments
Closed
2 tasks

Add support for multipart requests for Typescript #5256

rkodev opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code
Milestone

Comments

@rkodev
Copy link
Contributor

rkodev commented Aug 27, 2024

Add support to generate code with multipart requests. Schema's with multipart request currently cannot be generated for Typescript and is blocked by support implementation in kiota-typescript

  • Add support for multipart serialization in kiota-typescript
  • Enable multipart serialization for TS in kiota
@rkodev rkodev added the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Aug 27, 2024
@baywet baywet added this to the Kiota v1.18 milestone Aug 27, 2024
@baywet baywet added type:bug A broken experience TypeScript Pull requests that update Javascript code and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Aug 27, 2024
@rkodev rkodev self-assigned this Aug 29, 2024
@baywet baywet modified the milestones: Kiota v1.18, Kiota v1.19 Sep 5, 2024
@andrueastman
Copy link
Member

Looks like we have the multibody type present in the libs.
https://github.com/microsoft/kiota-typescript/blob/main/packages/abstractions/src/multipartBody.ts

Also, the serializer is present here
https://github.com/microsoft/kiota-typescript/tree/main/packages/serialization/multipart/src

Could this be a different bug?

@andrueastman
Copy link
Member

@rkodev With fixes made in microsoft/kiota-typescript#1399. Any chance you can confirm if this is still an issue and resolve/close?

From my perspective, kiota-typescript has the relevant types for multipart and the generator emits the information as expected.

The suppression here looks to possibly related to #5353 and not really multipart requests

"Rationale": "https://github.com/microsoft/kiota/issues/5256"

@rkodev
Copy link
Contributor Author

rkodev commented Oct 7, 2024

@andrueastman This seems to be resolved, I'll do ahead and close it

@rkodev rkodev closed this as completed Oct 7, 2024
@baywet baywet modified the milestones: Kiota v1.20, Kiota v1.19.1 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code
Projects
Status: Done ✔️
Development

No branches or pull requests

3 participants