Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Handler middleware (all languages) #5316

Open
esbenbach opened this issue Sep 4, 2024 · 7 comments
Open

Documentation for Handler middleware (all languages) #5316

esbenbach opened this issue Sep 4, 2024 · 7 comments
Labels
Csharp Pull requests that update .net code status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request

Comments

@esbenbach
Copy link

Is your feature request related to a problem? Please describe the problem.

I am trying to figure out how to customize the behaviour of the RetryHandler and also figuring out if the "TelemetryHandler" does anything at all, aside from providing a random hook into the request message being sent.

While I can browse the code, and "reverse engineer" an understanding, it would be really awesome with documentation describing what the various handlers are for, how they may be used and configured/customized.

As it stands, that seems to be almost impossible

Client library/SDK language

Csharp

Describe the solution you'd like

More documentation on the various existing/out-of-the-box middleware handlers :)

Additional context

No response

@esbenbach esbenbach added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Sep 4, 2024
@msgraph-bot msgraph-bot bot added the Csharp Pull requests that update .net code label Sep 4, 2024
@baywet
Copy link
Member

baywet commented Sep 4, 2024

Hi @esbenbach ,
Thank you for using kiota and for reaching out.

I was curious, did you find this page? https://learn.microsoft.com/en-us/openapi/kiota/middleware

@esbenbach
Copy link
Author

esbenbach commented Sep 4, 2024 via email

@baywet
Copy link
Member

baywet commented Sep 5, 2024

Thank you for the additional information.

So, what you'd expect to be added here would be:

  • a list of the available middleware handler.
  • a list of the handlers added by default to any client.
  • anything else?

Those are currently listed in our design repo but this repo is more reserved for internal design decisions and so our team has a reference when implementing functionality.

@esbenbach
Copy link
Author

esbenbach commented Sep 5, 2024 via email

@baywet
Copy link
Member

baywet commented Sep 5, 2024

Thank you for the additional information.
Follow up question, did you find this page ? would that answer the "how do customize the client handler?" part of the documentation gap for you?

@esbenbach
Copy link
Author

No i did not find a totally unrelated page about the MS Graph SDK. While it seems to be generated with Kiota, or at least uses the same principles, it still has a lot of other stuff, like the GraphClientFactory.

A similar example using a Kiota generated client would make sense in terms of customizations yes. Refering to the Graph SDK for an example would not (because then again I have to mentally exclude/ignore the parts that are graph sdk specific).

@baywet
Copy link
Member

baywet commented Sep 6, 2024

Thank you for the additional information.
While my question might have sounded naïve from the outside (yes those are two separate sections), better understanding the browsing patterns helps us produce better documentation.

Your feedback has helped scope this request a lot!

Is this something you'd like to submit a pull request for provided some guidance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

2 participants