Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class Summary could be reimplemented as an actual Abstract Base Class #44

Open
mpounsett opened this issue Feb 6, 2022 · 0 comments
Open

Class Summary could be reimplemented as an actual Abstract Base Class #44

mpounsett opened this issue Feb 6, 2022 · 0 comments
Labels
minor

Comments

@mpounsett
Copy link
Owner

mpounsett commented Feb 6, 2022 •
edited
Loading

Linting complains about the signatures of several methods in this class (no-self-use), and the issue could be resolved by reimplementing them as @staticmethod methods, but that might be API-breaking if anyone is making use of self references in subclassed implementations. If these can't be @staticmethod then they could be reimplemented as a proper ABC using the @abstractmethod decorator.
@mpounsett mpounsett changed the title Class Summary should be reimplemented as an actual Abstract Base Class Class Summary could be reimplemented as an actual Abstract Base Class Feb 6, 2022
mpounsett added a commit that referenced this issue Feb 6, 2022
@mpounsett
comment: several Summary methods should be reimplemented as static, o…
f35d68d 
…r as @AbstractMethod in order to quiet linting (see #44)
@mpounsett mpounsett added the minor label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpounsett