Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Glossary author OMVS should be solution view or integration view #173

Open
planetf1 opened this issue May 28, 2021 · 18 comments
Open

Glossary author OMVS should be solution view or integration view #173

planetf1 opened this issue May 28, 2021 · 18 comments
Labels

Comments

@planetf1
Copy link
Member

Using coco k8s environment testing 2.10

Dino throws the error:

View service Glossary Author OMVS should be configured as either a SolutionViewService or an IntegrationViewService

When navigating into cocoView1 -> View Services configuration

Screenshot 2021-05-28 at 11 11 14

@planetf1
Copy link
Member Author

Also occurs when clicking Server Stats/Audit Log -> Get Server Audit Log -- after getting the above error

@planetf1 planetf1 mentioned this issue May 28, 2021
26 tasks
@davidradl
Copy link
Member

davidradl commented May 30, 2021

I can't find that message you see in the alert in the code in either repository! The closest I found is

VIEW_SERVICE_CONFIG(400, "OMAG-ADMIN-400-042",
                         "The {0} Open Metadata View Service (OMVS) has been passed an invalid configuration of {1} in the {2} property.",
                         "The view service has not been passed valid configuration.",
                         "Check whether the view service expects SolutionViewServiceConfiguration or IntegrationViewServiceConfiguration, correct the configuration and restart the server.

But is not the same text as your popup. Also Dino does 2 alerts neither of them match what you see. Could this be out of date code; before Graham standardised the error processing.

When I get time I will attempt to recreate.

@mandy-chessell
Copy link
Contributor

The message is coming from egeria-react-ui/cra-client/src/components/Dino/components/details-panel/ServerConfigServicesDisplay.js

@mandy-chessell
Copy link
Contributor

This is the code:

const getServiceName = (service) => {
    let serviceName = null;
    switch (service.class) {
      /*
       * View Services
       */
      case "IntegrationViewServiceConfig":
        serviceName = service.viewServiceFullName;
        break;
      case "SolutionViewServiceConfig":
        serviceName = service.viewServiceFullName;
        break;
      case "ViewServiceConfig":
        alert("View service "+service.viewServiceFullName+" should be configured as either a SolutionViewService or an IntegrationViewService");
        serviceName = service.viewServiceFullName;
        break;
      /*
       * Access Services
       */
      case "AccessServiceConfig":
        serviceName = service.accessServiceFullName;
        break;
      
      default:
        console.log("getServiceName: does not yet support this type of service!");
        break;
    }
    return serviceName;
  }

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@davidradl
Copy link
Member

@mandy-chessell @planetf1 Thanks for the updates. I will have a look

@davidradl
Copy link
Member

@planetf1 @mandy-chessell

I have had a look at this. Graham had originally set up 2 child classes of ViewServiceConfig,
one for solutions and one for integration services. The original integration services added extra content, which is the resources and endpoints. The Solution service configs did not add extra content. I did not use this child class for Glossary Author - as there was no real need.

We either
1- allow glossary author to be defined with SolutionViewServiceConfig. If we do this we should not allow it to be defined
with IntegrationViewServiceConfig or ViewServiceConfig server side and in Dino. The advantage of this is that we could use the class to determine whether the config is an Integration or a solution view service explicitly. The downside is that there is extra complexity for little / no gain.
or
2-we remove the SolutionViewServiceConfig class, from the server and documentation and remove this checking from Dino. We could add in other child classes as the need arises. We can still use the class to identify the config as Integration or not. If it is not, then it would be a solution view config.

I am thinking 2) but wanted to know your thoughts.

@davidradl
Copy link
Member

@planetf1 @mandy-chessell I will proceed with 2) .

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@planetf1
Copy link
Member Author

Retested - issue has been fixed

@planetf1
Copy link
Member Author

Reopening, as this issue has reoccurred using 3.8.0-rc.0
It's possible it's intermittent:
Screenshot 2022-04-26 at 12 09 41

This occurs when selecting the view server ('view1' on coco) and trying to expand 'server configuration'

@planetf1 planetf1 reopened this Apr 26, 2022
@planetf1
Copy link
Member Author

when the message is closed, one can continue to view the config

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented May 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants