Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testfloat on VCS failing #911

Open
jordancarlin opened this issue Aug 12, 2024 · 0 comments
Open

Testfloat on VCS failing #911

jordancarlin opened this issue Aug 12, 2024 · 0 comments
Assignees

Comments

@jordancarlin
Copy link
Contributor

jordancarlin commented Aug 12, 2024

Testfloat support is added for VCS in #908, but it is not passing right now. There seem to be a few different distinct issues going on with it.

  • The final vector in a test file is being incorrectly read as all 1s. This seems to happen with most of the rne vectors.
$ wsim --tb testbench_fp --sim vcs f_ieee_rv32gc add
Error in f32_add_rne.tv
TestNum          0 VectorNum      46464 OpCtrl 6
inputs: ffffffff 3f800000 ffffffff
SrcA: xxxxxxxx
 Res: 7fffffff 00
 Expected: ffffffff 1f
  • Likely a separate issue, there is an off-by-one error for several test cases. This seems to happen with most of the non rne vectors.
    • Reproduce by commenting out f32_add_rne.tz and then running
$ wsim --tb testbench_fp --sim vcs f_ieee_rv32gc add
Running f32_add_rz.tv vectors 

Error in f32_add_rz.tv
TestNum          0 VectorNum          2 OpCtrl 6
inputs: 9ede38f7 3f800000 3e7f7f7f
SrcA: xxxxxxxx
 Res: 3e7f7f7f 01
 Expected: 3e7f7f7e 01

It is not totally consistent. The issues occur with add, sub, mul, fma, cvtint, and cmp but not with div, sqrt, or cvtfp.

@davidharrishmc davidharrishmc self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants