Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json dependencies on the provisioning plugin on the branch 4.15 looks to be outdated #69

Open
lavocatt opened this issue Jul 9, 2024 · 3 comments

Comments

@lavocatt
Copy link
Contributor

lavocatt commented Jul 9, 2024

When I'm checking out the branch 4.15, I'm expecting to find the version 1.0.0 for the dynamic plugin sdk, but I'm seeing 0.0.12

"@openshift-console/dynamic-plugin-sdk": "0.0.12",

What about the other dependencies in the file, are they up-to-date too?

@spadgett
Copy link
Member

spadgett commented Jul 9, 2024

We should verify that the README is correct and, if so, update the dependency in the 4.15 branch. It would be good to verify the older branches, too.

cc @jhadvig @vojtechszocs

@mikaello
Copy link
Contributor

mikaello commented Sep 6, 2024

It seems to be inconsistencies in the other branches as well, e.g release-4.16. The release notes for 4.16 says:

image

Source: https://docs.openshift.com/container-platform/4.16/release_notes/ocp-4-16-release-notes.html#ocp-4-16-web-console_release-notes

but in package.json react-router 5 is used:

"react-router": "5.3.x",
"react-router-dom": "5.3.x",

@spadgett
Copy link
Member

spadgett commented Sep 6, 2024

@mikaello Thanks for raising this. I believe we still expect to have the older package in the dependencies to give developers time to migrate to v6. It's deprecated, but still there for compatibility. You can use the react-router-dom-v5-compat dependency to begin migrating to v6 if your plugin targets only OpenShift 4.15+.

See https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/README.md#changes-in-shared-modules

@vojtechszocs @jhadvig Can you confirm? I think we should improve the docs around the react-router migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants