Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dimension independence (avoid needing to set AMReX_SPACEDIM) #686

Open
BenWibking opened this issue Jul 26, 2024 · 0 comments
Open

dimension independence (avoid needing to set AMReX_SPACEDIM) #686

BenWibking opened this issue Jul 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@BenWibking
Copy link
Collaborator

BenWibking commented Jul 26, 2024

Describe the proposal
In principle, we can build Quokka in a dimension-independent way, such that we don't need to set AMReX_SPACEDIM.

In practice, this will require setting AMReX_SPACEDIM=3 and then modifying the code to handle the case when Ny==1 and Nz==1 (for 1D sims) or when Nz==1 (for 2D sims) as special cases.

Describe alternatives you've considered
Keep the code as-is (re-build with different values of AMReX_SPACEDIM for different problems).

Additional context
Some new features in AMReX may make the code changes easier: AMReX-Codes/amrex#4016.
See also: AMReX-Codes/amrex#3955

@BenWibking BenWibking added the enhancement New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant