Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to FSDP #51

Open
MichaelClifford opened this issue Oct 2, 2024 · 0 comments
Open

Switch to FSDP #51

MichaelClifford opened this issue Oct 2, 2024 · 0 comments

Comments

@MichaelClifford
Copy link
Collaborator

FSDP is toolkit for distributed model training. It is an alternative to Deepspeed. The InstructLab team has added support for FSDP in addition to DeepSpeed in their training repo and we would like to implement FSDP instead of DeepSpeed here.

Please see instructlab/training#235 for the relevant changes.

Hopefully this change should not impact our code base significantly, and should primarily consist of updating our TrainingArgs here:

training_args = TrainingArgs(
deepspeed_options = DeepSpeedOptions(cpu_offload_optimizer=args.cpu_offload),

Since this script is included in our PytorchJob image, the image will also need to be rebuilt to fully implement this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant