Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU requests aren't set on redpanda statefulset unless min memory is specified. #1494

Open
supernomad opened this issue Aug 20, 2024 · 0 comments

Comments

@supernomad
Copy link

supernomad commented Aug 20, 2024

What happened?

We expected to have CPU requests set for all pods, however we are not setting a minimum amount of memory in the helm chart. This results in a statefulset with CPU limits but no requests.

What did you expect to happen?

We expected the statefulset to have both requests/limits for at least CPU since it was specified in the values file.

How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

Deploy the helm chart without a minimum memory limit specified, and observe the statefulset lacking a CPU requests configuration.

Anything else we need to know?

We took a peak at the code and it seems like a small bug here: https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/statefulset.go#L762-L772 where the requests are only set if the minimum memory value is specified.

Which are the affected charts?

Redpanda

Chart Version(s)

5.8.12

Cloud provider

GCP

JIRA Link: K8S-325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant