Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack 4 compatibility #33

Open
lmmarsano opened this issue Mar 21, 2018 · 1 comment
Open

webpack 4 compatibility #33

lmmarsano opened this issue Mar 21, 2018 · 1 comment

Comments

@lmmarsano
Copy link

With the environment

$ npm ls --depth 0 webpack reshape-loader
/home/luism/project/journal
├── [email protected] 
└── [email protected]

webpack -d outputs the error

Module build failed: TypeError: this._compiler.applyPlugins is not a function
    at Object.module.exports (/home/luism/project/journal/node_modules/reshape-loader/lib/index.js:26:18)

Looking at

I gather this may have something to do with method applyPlugins deprecation.
Any plans to support webpack 4?

Steps to Reproduce

git clone https://github.com/reshape/loader.git
cd loader/
npm install -D webpack@latest
npm install
npm test

The first test fails with the same error.

  basic

  Rejected promise returned by test. Reason:

  {
    err: [
      ModuleBuildError {
        dependencies: Array [ … ],
        error: TypeError { … },
        message: `Module build failed: TypeError: this._compiler.applyPlugins is not a function␊
            at Object.module.exports (/home/luism/project/loader/lib/index.js:8:39)`,
        module: NormalModule { … },
        origin: NormalModule { … },
      },
    ],
    outputPath: '/home/luism/project/loader/test/fixtures/basic/bundle.js',
  }
@jescalan
Copy link
Member

Hi there! Reshape-loader is not compatible with webpack 4 at all. Webpack 4 is massively breaking for just about every loader and plugin, it's an incredible amount of work to upgrade deeply integrated loaders like this, webpack still does not have an official migration guide, and I have a ton of work on my plate, so I haven't been able to get to it.

If you are interested in helping out with getting reshape-loader to webpack 4 compatibility, that would be amazing, and I'd be happy to advise best I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants