Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qustion about the hemisphere filter method in drop_mismatch_samples function (samples_.py L223) #218

Open
YCHuang0610 opened this issue Aug 8, 2023 · 0 comments

Comments

@YCHuang0610
Copy link

YCHuang0610 commented Aug 8, 2023

https://github.com/rmarkello/abagen/blob/6f5542522247b9a7fb00ded198c34f4dc25957f3/abagen/samples_.py#L220C1-L224C46

Line 220-224 in samples_.py

annot = annotation.assign(hemisphere=hemisphere, structure=structure) \
                  .query('(hemisphere == "L" & mni_x < 0) '
                         '| (hemisphere == "R" & mni_x > 0) '
                         '| (hemisphere == "B" & mni_x == 0)',
                         engine='python')

Some of the samples in AHBA were not annotated hemisphere, such as 4700, Ve-I-II; 4701, Ve-III in donor 9861.
In samples_.py#L223, the samples that are not annotated hemispheres and have a non-zero mni_x will be removed. This probably causes that all the samples without annotated hemispheres will be filtered out at this step, because no sample has a mni_x of 0.
I am wondering is this resonable?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant