Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify status of support of stateful systems #7

Open
traversaro opened this issue Dec 23, 2018 · 3 comments
Open

Clarify status of support of stateful systems #7

traversaro opened this issue Dec 23, 2018 · 3 comments

Comments

@traversaro
Copy link
Member

traversaro commented Dec 23, 2018

The blockfactory::core::Block interface of blockfactory support the following methods that seem to indicate that it supports discrete and continuous stateful systems:

  • blockfactory::core::Block::numberOfDiscreteStates()
  • blockfactory::core::Block::numberOfContinuousStates()
  • blockfactory::core::Block::updateDiscreteState(const BlockInformation* blockInfo)
  • blockfactory::core::Block::stateDerivative(const BlockInformation* blockInfo)

however in practice it is not clear if these functions are used at all and how they are supposed to be used, as BlockInformation contain no state information at all. It may be worth to document that this methods are not used at all, and eventually remove that notice when will support stateful systems.

@traversaro traversaro changed the title Clarify status of support of stateful systems- Clarify status of support of stateful systems Dec 23, 2018
@traversaro
Copy link
Member Author

Until we properly support stateful systems, it may be also reasonable to remove calls to updateDiscreteState such as https://github.com/robotology/blockfactory/blob/master/sources/Mex/src/BlockFactory.cpp#L280 .

@diegoferigo
Copy link
Member

the following methods that seem to indicate that it supports discrete and continuous stateful systems

Few comments on this:

  • We never tried to exploit blockfactory for continuous system, all our experience with wb-toolbox consisted of discrete ones.
  • For what concern instead discrete systems, we already have stateful blocks. For example the DiscreteFilter retains previous data in its implementation, however it does not exploit anything provided by BlockFactory and the methods you reported. There is just a note in the documentation of core::Block.

@traversaro
Copy link
Member Author

For what concern instead discrete systems, we already have stateful blocks. For example the DiscreteFilter retains previous data in its implementation, however it does not exploit anything provided by BlockFactory and the methods you reported. There is just a note in the documentation of core::Block.

Related WB-Toolbox discussion: robotology/wb-toolbox#165 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants