change dependents in third step very slow

[dirk-thomas]

Changing dependents in the third step is painfully slow. Every time a single item is being clicked the load indicator is spinning for several seconds. Therefore changing more than a couple of items is a painfully slow process.

@wjwwood Since you implemented this part afaik maybe you can comment why that part is so slow and/or if it can be improved?

[wjwwood]

I'll try to have a look at it soon.

[wjwwood]

This is the function that is slow:

https://github.com/ros-infrastructure/prerelease_website/blob/master/prerelease_website/submit_jobs/ajax.py#L120-L171

I believe most of the time is spent in the call to the generate_prerelease_overlay_script.py ... --json call, which needs to do a lot of work and potentially has to fetch the rosdistro cache, IIRC.

I don't have any specific suggestions to speed it up.

[dirk-thomas]

This is currently preventing me from generating any command lines for e.g. ros_comm in Kinetic. The process is running for 20+ min. and doesn't finish. And I am unable to change the depth to 0.

As a temporary workaround I would suggest to start with a default depth of 0.

[mikaelarguedas]

How weird, just tried it and in took less than 30 seconds o_O Maybe the page hang for another reason ?

mkdir -p /tmp/prerelease_job
cd /tmp/prerelease_job
generate_prerelease_script.py \
  https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml \
  kinetic default ubuntu xenial amd64 \
  ros_comm \
  --level 1 \
  --output-dir ./