Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider capturing the provided dirty suffix #28

Open
dwijnand opened this issue Feb 22, 2017 · 2 comments
Open

Consider capturing the provided dirty suffix #28

dwijnand opened this issue Feb 22, 2017 · 2 comments

Comments

@dwijnand
Copy link
Member

By default a fallback version the dirty suffix is used: HEAD+timestamp.

Currently getGitDescribeOutput takes a date but returns an Option, so in the None case the date is not accessible.
@dwijnand
Copy link
Member Author

This avoids having to hold onto the date to use it twice.

@dwijnand
Copy link
Member Author

This would remove the need for dynverCurrentDate, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwijnand