Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual tests #4

Open
ast0815 opened this issue May 16, 2020 · 3 comments
Open

Actual tests #4

ast0815 opened this issue May 16, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ast0815
Copy link
Collaborator

ast0815 commented May 16, 2020

Would be good to have some tests that can actually fail instead of depending on visual checks.

@ast0815 ast0815 added the enhancement New feature or request label May 16, 2020
@eduardo-rodrigues
Copy link
Member

Any thoughts on what to add?

@ast0815
Copy link
Collaborator Author

ast0815 commented May 22, 2021

We could check for an exact match in an output string of a histogram, but I'm not sure that is very useful. I guess it would add more extra work (to keep the comparison string up-to-date) than it's worth.

@eduardo-rodrigues
Copy link
Member

That's fair enough. One idea might be to profit from the fact that you interoperate well with boost-histogram and simply add a couple of comparisons after the conversion. It's not a pure/direct test, but that's probably OK enough. Dunno if @henryiii would have some other idea ... Otherwise you can probably close this task as done, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants