Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require buttonComponent to accept ref #87

Open
gustavoguichard opened this issue Oct 6, 2022 · 3 comments
Open

Require buttonComponent to accept ref #87

gustavoguichard opened this issue Oct 6, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@gustavoguichard
Copy link
Contributor

No description provided.

@diogob diogob added the enhancement New feature or request label Nov 7, 2022
@diogob diogob self-assigned this Nov 7, 2022
@diogob
Copy link
Contributor

diogob commented Nov 7, 2022

Inputs will take the ref prop in the component resulting from createForm, the buttonComponent should follow the same standard.

@Roanmh
Copy link

Roanmh commented Jan 5, 2024

Hi,

We have recently run into a problem similar to #194. It seems like this enhancement would resolve that issue as well as ours. What is the status of this work?

In our case, We are using the Button component from Shadcn/ui. It uses React.ForwardRef for interactions with other components, but this is incompatible with the buttonComponent prop on the createForm component because the prop is not expecting a component with a ref. We would like to avoid splitting/wrapping the component just to use it as a form submit button.

Thanks in advance,
Roan

@diogob
Copy link
Contributor

diogob commented Jan 10, 2024

@danielweinmann thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants