Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on Windows #1604

Closed
mhalbritter opened this issue Oct 1, 2024 · 4 comments
Closed

Unable to build on Windows #1604

mhalbritter opened this issue Oct 1, 2024 · 4 comments

Comments

@mhalbritter
Copy link
Contributor

The project can't be built on Windows. I've added a Windows CI, which is currently failing.

@Jayanta0123
Copy link

Jayanta0123 commented Oct 3, 2024

@mhalbritter,
I could see the all the differences in expected vs actual in the failed tests are with the whitespaces only.
image

All the 6 tests within that particular class TestcontainersProjectGenerationConfigurationTests are failing, and reasons of failure is the same for all.

@Jayanta0123
Copy link

@mhalbritter, @ngocnhan-tran1996

Pls note, the issue is resolved now from the windows build point of view. But one has to add the build option spring-javaformat:apply on the build option. I prefer this to be added in pom.xml in a future boot-release. Thanks.

image

@mhalbritter
Copy link
Contributor Author

mhalbritter commented Oct 7, 2024

Hmm, what do you mean?

If you have local changes and want them to be formatted according to the style, you have to run spring-javaformat:apply. When you don't have local changes, this shouldn't be necessary.

The CI on Windows now passes: https://github.com/spring-io/start.spring.io/actions/runs/11212213990/job/31162758346

@mhalbritter
Copy link
Contributor Author

Fixed by #1605, thanks @ngocnhan-tran1996!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants