Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithTx should accept a DBTX interface instance, not a concrete *sql.Tx or pgx.Tx for Go. #3603

Open
urandom opened this issue Sep 12, 2024 · 0 comments
Open

WithTx should accept a DBTX interface instance, not a concrete *sql.Tx or pgx.Tx for Go. #3603

urandom opened this issue Sep 12, 2024 · 0 comments
Labels
📚 postgresql enhancement New feature or request 🔧 golang

Comments

@urandom
Copy link

urandom commented Sep 12, 2024

What do you want to change?

Currently, when the WithTx method is generated, it accepts a concrete type: either an *sql.Tx or a pgx.Tx. However, the arguments ends up being assigned to a DBTX-typed field. The argument then should also be of type DBTX

What database engines need to be changed?

PostgreSQL

What programming language backends need to be changed?

Go
@urandom urandom added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 postgresql enhancement New feature or request 🔧 golang
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@urandom