Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Add TypeDict for Launch Data and more type hints #133

Open
jonespm opened this issue Apr 11, 2022 · 0 comments
Open

Add TypeDict for Launch Data and more type hints #133

jonespm opened this issue Apr 11, 2022 · 0 comments
Labels
backend enhancement New feature or request

Comments

@jonespm
Copy link
Member

jonespm commented Apr 11, 2022

This project could use more type hinting. It was noted that pylti13 has typehints that we could use.

Yeah, they do have a TypedDict for Launch Data. I could add this. I haven't been doing typing in this project except a little (inconsistently) for this file. :(

https://github.com/dmitry-viskov/pylti1.3/blob/476556aa5b13da20be591b6aea4b4f61b85ea8fe/pylti1p3/message_launch.py#L113

Originally posted by @jonespm in #98 (comment)
@ssciolla ssciolla added enhancement New feature or request backend labels Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonespm @ssciolla