Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Validate the launch closer to the actual launch #262

Open
jonespm opened this issue Aug 1, 2022 · 0 comments · May be fixed by #270 or #277
Open

Validate the launch closer to the actual launch #262

jonespm opened this issue Aug 1, 2022 · 0 comments · May be fixed by #270 or #277
Labels
backend bug Something isn't working

Comments

@jonespm
Copy link
Member

jonespm commented Aug 1, 2022

I believe some issues with launch validation might be because we are waiting a bit to do any launch validation.

If we explicitly validate the launch immediately after the launch we shouldn't encounter issues with the validation not matching, and if so be able to handle it better in our code.

https://github.com/dmitry-viskov/pylti1.3#lti-message-launches

I'm not sure if we'd need to implement any locking around this. We're doing more testing. I believe that if the testing is successful just having a validate closer to the launch should be sufficient.

message_launch = ExtendedDjangoMessageLaunch(request, TOOL_CONF, launch_data_storage=CacheConfig.launch_data_storage)

@jonespm jonespm added the backend label Aug 1, 2022
@ssciolla ssciolla added the bug Something isn't working label Aug 4, 2022
@ssciolla ssciolla linked a pull request Oct 4, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Something isn't working
Projects
None yet
2 participants