Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimme stable does not work for latest Go (v1.21.0) #210

Open
psx95 opened this issue Aug 14, 2023 · 8 comments
Open

gimme stable does not work for latest Go (v1.21.0) #210

psx95 opened this issue Aug 14, 2023 · 8 comments
Assignees

Comments

@psx95
Copy link

psx95 commented Aug 14, 2023

Running gimme stable now results in the following output -

/tmp/bin/gimme stable 
I don't have any idea what to do with '1.21.0
time 2023-08-04T20:14:06Z'.
  (using download type 'auto')

It seems like the timestamp is being added to the Go version string which is why the version is not found and the command fails. Pinning the version number is a workaround for now.

gimme 1.21.0
@YOwatari
Copy link

I created a fix, but the maintainer is not responding 😢
#209

@siris
Copy link

siris commented Aug 18, 2023

In Funtoo Linux I have been able to reproduce this bug as well when attempting to compile the new kubectl-1.28.0 (which contains the affected gimme version of v1.5.4): https://bugs.funtoo.org/browse/FL-11522

>>> Compiling source in /var/tmp/portage/sys-cluster/kubectl-1.28.0/work/kubectl-1.28.0 ...
make -j15 -j1 GOFLAGS= GOLDFLAGS= LDFLAGS= WHAT=cmd/kubectl
I don't have any idea what to do with '1.20.7'.
  (using download type 'auto')

@psx95
Copy link
Author

psx95 commented Aug 18, 2023

I created a fix, but the maintainer is not responding 😢 #209

I upvoted the PR, not sure if it would help though. Last release for this repo was over an year ago so not sure if it is still being maintained.

@onwsk8r
Copy link

onwsk8r commented Oct 25, 2023

@YOwatari your PR's build failed here and here:

---> eval $(GIMME_OS=linux GIMME_ARCH=arm ./gimme master)
I don't have any idea what to do with 'master'.
  (using download type 'auto')

Maybe they will merge your PR if you make the build pass

@YOwatari
Copy link

The test fails regardless of my patch.
Maybe there is no maintainer and no one has seen it.

@YOwatari
Copy link

I made some additional fixes so that the test would pass. :)

@onwsk8r
Copy link

onwsk8r commented Oct 27, 2023

Awesome work @YOwatari - I know it was a separate issue that was keeping those tests from passing, and thank you for taking the time to bring Gimme into 2023.

@onwsk8r
Copy link

onwsk8r commented Oct 27, 2023

I sent Travis an email at [email protected] - maybe if you all do the same, they will take some responsibility for their software and we can get this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants