Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HidingNavigationBarManager conflicts with refreshControl #27

Open
benjaminhorner opened this issue Feb 23, 2016 · 6 comments
Open

HidingNavigationBarManager conflicts with refreshControl #27

benjaminhorner opened this issue Feb 23, 2016 · 6 comments

Comments

@benjaminhorner
Copy link

If I use HidingNavigationBarManager on UICollectionView or UITableView with a refresh control, the HidingNavigationBarManager totally breaks the refresh control.

The refresh becomes jitty and is even sometimes hidden.

I am guessing this has to do with the fact that the HidingNavigationBarManager is doing stuff to the collectionView inset.

Maybe implement a listener to "kill" the HidingNavigationBarManager during refresh…

NOTE: I am implementing
self.hidingNavBarManager?.refreshControl = self.refreshControl

This happens on a UICollectionView with a custom layout. I haven't checked on a standard layout nor on a UITableView

@tcrous
Copy link

tcrous commented Mar 14, 2016

I experience the same with a UITableViewController :-(

@axmav
Copy link

axmav commented Oct 15, 2016

Have the same problem. RefreshControl hides when refreshing (UITableViewController).
Does anyone solve this problem?
Thanks!

@Skyrect
Copy link

Skyrect commented Nov 17, 2016

@benjaminhorner , @tcrous , @Mazorati i use hack, set your tableview constraint 12 or any desire number you like from the top
screen shot 2016-11-17 at 10 43 15 pm

@welbesw
Copy link

welbesw commented Feb 7, 2017

Experiencing the same issue with UIRefreshControl on UITableView with hiding nav bar and tab bar.

@skg54
Copy link

skg54 commented May 15, 2019

Not using a UITableViewController but UITableView as a subview and was experiencing similar sounding problems with UIRefreshControl. Setting the following properties on the UIViewController fixed the UIRefreshControl problems.

self.extendedLayoutIncludesOpaqueBars = YES;
self.automaticallyAdjustsScrollViewInsets = NO;

@robrichardson13
Copy link

For me, I was able to add this code to the source of HidingNavigationBarManager.swift at the top of the updateContentInsets() function.

if refreshControl?.isRefreshing == true { return }

It looks like the issue is caused when the content insets are updating as the refreshControl is loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants