Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

videojs-playlist.js build calls incorrect function #264

Open
d3athrow opened this issue Jun 27, 2024 · 1 comment · May be fixed by #265
Open

videojs-playlist.js build calls incorrect function #264

d3athrow opened this issue Jun 27, 2024 · 1 comment · May be fixed by #265

Comments

@d3athrow
Copy link

Description

Briefly describe the issue.
Include a reduced test case.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Build new dist
  2. Load test page
  3. get error

Results

Expected

Please describe what you expected to see.
No error

Actual

Please describe what actually happened.
Error in console

Error output

If there are any errors at all, please include them here.

Uncaught TypeError: this.playlist_.get is not a function
    at PlaylistPlugin.loadPlaylistItem (videojs-playlist.js:651:36)
    at PlaylistPlugin.loadFirstItem (videojs-playlist.js:669:19)```
## Additional Information
Please include any additional information necessary here. Including the following:

### versions
#### videojs
what version of videojs does this occur with?
whatever is defined in package.json
#### browsers
what browser are affected?

#### OSes
what platforms (operating systems and devices) are affected?

### plugins
are any videojs plugins being used on the page? If so, please list them below.
NO


.get() does not exist, it should be .getItems()
@mister-ben mister-ben linked a pull request Jun 28, 2024 that will close this issue
Open
5 tasks
@mister-ben
Copy link
Contributor

Thanks for the report. If you weren't aware, note the main branch is the v6 release candidate. v5.1.2 reflects latest on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Replace get() with getItems videojs/videojs-playlist
2 participants
@d3athrow @mister-ben