Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present a warning during warden env up if warden svc up / warden install needs to be re-ran due to an operating system upgrade #644

Open
navarr opened this issue Apr 10, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@navarr
Copy link
Member

navarr commented Apr 10, 2023

No description provided.

@navarr navarr added the enhancement New feature or request label Apr 10, 2023
@navarr navarr added this to the Warden 1.0.0 milestone Apr 10, 2023
@navarr navarr self-assigned this Apr 10, 2023
@Vinai
Copy link
Contributor

Vinai commented Apr 11, 2023

Thank you 👍 :)

@hardyjohnson
Copy link
Contributor

How do you see this working? Currently I believe the installSshConfig estimates an operating systems upgrade if it doesn't find an expected SSH config string.

Does writing an OS version file (~/.warden/os/version) which could be compared against make sense?

@bap14
Copy link
Member

bap14 commented May 1, 2024

@hardyjohnson I don't think that's necessary. It's really just a check of:

  1. Is warden installation complete?
    1. The necessary files / services are defined / available
  2. Is Warden running?
    1. Are the necessary services available?

So this is really just adding some checks to the start of warden env command to ensure it's all good.

The problems i see are:

  1. What files / services do we need to look for?
  2. This will add time to the start up of the warden env command which will slow it down

@hardyjohnson
Copy link
Contributor

hardyjohnson commented May 1, 2024

@bap14 thank you for clarifying. I didn't think this was truly about operating system upgrades.

As a user when I call warden env up it should:

  1. Check if Warden is installed and configured
    • warden svc calls ./utils/install.sh::assertWardenInstalled that could be added to env calls as well or we could test for existence of ${WARDEN_HOME_DIR}/.installed as a proxy w/out ever launching the install sequence which that method does if the file is not found. Note the assert function is called in the svc command.
    • Call /utils/install.sh::installSshConfig or run the grep manually to see if ssh is already configured, output message if not configured.
  2. Check and display a message if global services are not running.
    • There is code in the warden status command which determines global services are running by estimating that the docker network list returns a non null response. This may not be as detailed or accurate as desired.

Does this encapsulate the thinking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants