ymlfxr removes comments from yaml files

[jayvdb]

There are quite a few YAML features not supported by https://github.com/chyh1990/yaml-rust that are mentioned in the issues there, and there seems to be a maintenance problem there also (chyh1990/yaml-rust#160), but I think it is worth calling out that comments are lost. chyh1990/yaml-rust#146 is the upstream issue for that.

[jayvdb]

IMO it would be worth adding support for another YAML lib if we can find one which supports comments - probably the libyaml based crates. Then the ymlfxr can choose which sets of yaml features they need.

[xbcsmith]

I am good with figuring out how to preserve comments. The main goal of the project was to format yaml to pass yamllint without doing anything. As long as we meet that I am fine figuring something out.

[jayvdb]

Ya, I agree with you. That removes libyaml crate as an option due to yaml/libyaml#224 . c.f. dtolnay/serde-yaml#337 where we've found that https://github.com/pantoniou/libfyaml may be a solution.