Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the map editor #11784

Open
2 tasks done
hugo-lezigoto opened this issue Jun 18, 2024 · 8 comments
Open
2 tasks done

Improvements for the map editor #11784

hugo-lezigoto opened this issue Jun 18, 2024 · 8 comments
Labels

Comments

@hugo-lezigoto
Copy link

hugo-lezigoto commented Jun 18, 2024

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

Recently, I have started to build maps and I have seen some improvements that can be done to improve the map editor.

Related Issue Links

No response

Desired Solution

1- an autosave system that save your map by itself every few minutes for exemples

2- an "control z" option to go back and undo the action you just did

3- differents shape of "pencils" when you are placing differents types of terrain, this can be used to create shapes more easily

Alternative Approaches

No response

Additional Context

Sorry if I made english errors in my texts,
anyway awsome game, continue like this.

@hackedpassword
Copy link

Your first idea does seem practical. Think we've been looking for an undo function for a while, might happen one day. As for shapes, that doesn't seem practical since the brush can scale 1-5 tile radius, and you could potentially use another smaller size to carve into a bigger brush. Using combinations of brushes and floodfill you should be able to get the desired result.

@SomeTroglodyte
Copy link
Collaborator

Map editor already has a long list of to-do's: https://github.com/yairm210/Unciv/blob/master/core/src/com/unciv/ui/screens/mapeditorscreen/MapEditorScreen.kt#L45-L60

... and back then I didn't even bother to write down the undo, seemed too costly to me. Back then the normal game didn't have undo either. Needs either a complete transaction system with rollback-able change descriptors, or a deep clone per undo level -> RAM. Or autosave each mini edit step to disk...
Shaped brushes - far too complicated. As you can see I had thought of a "hexagonal copy-paste" brush type...

But the first todo is more important and unless someone deals with that first (and it doesn't seem like a fun pastime to me either atm), I'd vote against any other changes.

@hackedpassword
Copy link

So is it infeasible to retain the last map click action and pass that back as a forward-motion negation of the same action?

@hackedpassword
Copy link

Actually, that sounded like a good idea, til loss of tile info wouldn't be restored. Just Gotta Do It Right

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Sep 18, 2024
@yairm210
Copy link
Owner

Keepalive - these are good ideas :)

@github-actions github-actions bot removed the Stale label Sep 19, 2024
@hackedpassword
Copy link

I still don't understand why I can on/off a river toggle-apply-remove, but features, resources, improvements, spawns don't have the same behavior. Surely that's not as involved as an undo :D

@yairm210
Copy link
Owner

🤔
That's a good idea, definitely easier than general undo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants