Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource density in editor on Android failing #12181

Open
2 tasks done
hackedpassword opened this issue Sep 3, 2024 · 6 comments
Open
2 tasks done

Resource density in editor on Android failing #12181

hackedpassword opened this issue Sep 3, 2024 · 6 comments
Labels

Comments

@hackedpassword
Copy link

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

Building a custom map. Done mapping, now I want to auto generate resources vs hand place them. Problem is, there's only one setting for resource generation: firehose.

Screenshot_20240903-035650_Unciv
Screenshot_20240903_100915

Related Issue Links

No response

Desired Solution

Showing 'resource richness' under New Map -> Advanced Settings even though it has no effect on partial generation. But imo, it should.

Alternative Approaches

'create ancient ruins' should be controlled by 'resource richness' or another slider.

Additional Context

Basically partial map steps look to advanced settings for variance control.

@yairm210
Copy link
Owner

yairm210 commented Sep 4, 2024

When I change the resource richness and then activate "spread resources" I see that it did affect the generation

@hackedpassword
Copy link
Author

Hmm, I'll look further. Why would it work for you but not me... I'll also try a comparison of android vs pc, see if that has any impact. Thanks for looking, will check back later.

@hackedpassword
Copy link
Author

Indeed it does. The issue apparently is that on Android, advanced settings aren't respected. Works on the PC.

Android Unciv 4.13.4
PC Unciv 4.12.19

Android 12, galaxy s10

Guess this feature request turned into a bug report :/

@hackedpassword hackedpassword changed the title Feature request: Control resource density in editor Resource density in editor on Android failing Sep 5, 2024
@yairm210
Copy link
Owner

yairm210 commented Sep 5, 2024

That's weird as hell!
I'll check it out

@yairm210 yairm210 added bug and removed feature labels Sep 23, 2024
@SomeTroglodyte
Copy link
Collaborator

I don't think it's Android vs. jar, it's more likely the exact sequence of steps. Could be the generator gets a decoupled clone of the MapParameters class at some point, meaning the Generator and the UI see separate instances after certain steps but not with some other history of steps/save,quit,load/whatever?

I seem to remember I had to go with two separate instances of GameParameters relevant to the map editor at any one time - one with the map and one with the UI, in order to make changing Mods behave as desired? Something like that.

@hackedpassword
Copy link
Author

My temp solution is:

  1. use the PC to gen resources, ala atlas
  2. DIY TLC <3

For this map I went DIY. Less involved maps I'd prob go pc gen which would have saved me a few days, but this one earned the TLC it got, in the end glad I was routed to place them manually =) doing actual work vs automated tools pfffffft what is this 1998 lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants